Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: redux: add unit tests #2934

Merged
merged 1 commit into from
Feb 21, 2025
Merged

frontend: redux: add unit tests #2934

merged 1 commit into from
Feb 21, 2025
+217 −0

Conversation

DhairyaMajmudar
Copy link
Contributor

Description

Adds units tests for redux slices:

  1. actionButtonSlice
  2. configSlice
  3. overciewChartsSlice

Testing

All existing and newly added tests are running perfectly

image

@DhairyaMajmudar
frontend: redux: add unit tests
69479ad 
Signed-off-by: Dhairya Majmudar <[email protected]>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 21, 2025
illume
illume approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you. Nice work.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 21, 2025
@illume illume merged commit 3aef920 into headlamp-k8s:main Feb 21, 2025
15 checks passed
@DhairyaMajmudar DhairyaMajmudar deleted the frontend/redux-tests branch February 21, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illume illume illume approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DhairyaMajmudar @illume