-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add numpy
to the deps
of scipy-stubs
#137
add numpy
to the deps
of scipy-stubs
#137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Looks like this was added in #136... When I run mypy_primer -k scipy-stubs --debug
, I get mypy: can't read file 'tests/**/*.py': No such file or directory
. So effectively when using mypy as the type checker, nothing is getting checked.
Hm weird... It's a classic case of "but it works on my (linux) machine". I'm guessing I should remove this line then?: edit: I opened scipy/scipy-stubs#486 edit edit: I merged scipy/scipy-stubs#486, could you try again to see if it works now? |
I now get On the old scipy-stubs commit, I can repro on Linux as well. Any chance this is a basedmypy vs mypy difference? |
Looks to be working with your 486 PR and #139 |
Yea, might be then.
Pfew, ok; thanks for looking into it! |
Great! Thanks for the addition |
I left it out earlier because
scipy
already requiresnumpy
.But by explicitly adding
numpy
todeps
,scipy-stubs
will also be selected when--known-dependency-selector=numpy
is passed, as e.g.numpy
itself does.