Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3031: implement tuh_midi_itf_get_info() #3032

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

rppicomidi
Copy link
Contributor

Describe the PR
See #3031

Additional context
See #3031

@hathach
Copy link
Owner

hathach commented Mar 17, 2025

can you rebase master to fix ci

@rppicomidi
Copy link
Contributor Author

I rebased and pushed. The code builds on my system. The diff shows only my changes. What is broken?

@hathach
Copy link
Owner

hathach commented Mar 18, 2025

I rebased and pushed. The code builds on my system. The diff shows only my changes. What is broken?

previously pio-usb is pointed to my wip fork, but that is merged upstream and the branch is deleted. Seem like your PR still have issue with conversion warnings. Please try to fix that.

@rppicomidi
Copy link
Contributor Author

Thank you. I found out how to view the detailed build logs and finally saw the error.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you

@hathach hathach merged commit c2924c5 into hathach:master Mar 20, 2025
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants