-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use prettyprinter instead of ansi-wl-pprint #77
Conversation
@@ -109,7 +109,7 @@ import Data.These (These (..)) | |||
-- primitive | |||
import qualified Data.Primitive as Prim | |||
|
|||
#if MIN_VERSION_base(4,9,0) | |||
#if MIN_VERSION_base(4,17,0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if I was doing something weird, but this module seems to only exist in base >=4.17, that's why I updated this cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is shimmed in https://hackage.haskell.org/package/data-array-byte
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't accept this change as such. It's a breaking change.
I have thought about how to do this and the streps are:
- add
prettyprinter
dependency (behind a manual flag) and functionality similarly how there are printers usingpretty
andansi-wl-pprint
. - make
ansi-wl-pprint
dependency behind a flag too (enabled) - make
ansi-wl-pprint
flag disabled by default. Later, as that will be a breaking change.
But I'm unsure about this. Maybe I won't do flags, but rather a companion packages.
@@ -109,7 +109,7 @@ import Data.These (These (..)) | |||
-- primitive | |||
import qualified Data.Primitive as Prim | |||
|
|||
#if MIN_VERSION_base(4,9,0) | |||
#if MIN_VERSION_base(4,17,0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is shimmed in https://hackage.haskell.org/package/data-array-byte
Any way to move forward on this? The rest of the ecosystem has moved on but |
What you mean by that? |
@phadej See #91, an upstream change in
The only way to fix this is by using |
I didn't do anything fancy, just "inlining" what I found in
prettyprinter-compat-ansi-wl-pprint
.