New package happy-lib; make previous happy-* packages sublibraries (#288)
#297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgraf812
force-pushed
the
wip/T288-2
branch
2 times, most recently
from
42fada1
to
44a68b2
Compare
int-index
reviewed
Sep 14, 2024
| Happy.Frontend.AttrGrammar.Parser | ||
| Happy.Frontend.AttrGrammar.Mangler | ||
|
|
||
| library tabular |
There was a problem hiding this comment.
What's the relation between this library tabular subsection and lib/tabular/happy-tabular.cabal? I didn't expect to see the latter.
There was a problem hiding this comment.
I think we can just remove the others?
There was a problem hiding this comment.
Good point, I forgot to remove the .cabal files. The main thing about this approach :)
Should be done now.
Ericson2314
reviewed
Sep 14, 2024
There was a problem hiding this comment.
Same question as @int-index about old cabal files, but very big +1 on the design!
sgraf812
force-pushed
the
wip/T288-2
branch
from
44a68b2
to
86b4f0f
Compare
int-index
approved these changes
Sep 15, 2024
|
Alright then, let's do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one design design discussed in #288.
Fixes #288.