Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemement foldr, foldl', sum and product in Foldable Tree #881

Closed
wants to merge 1 commit into from

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Dec 11, 2022

Addresses #878

With this patch on my machine:

All
  foldMap'Tree Sum: OK (0.31s)
    18.8 ms ± 1.9 ms
  sum:              OK (1.42s)
    18.0 ms ± 761 μs

This patch "changes" the strictness of sum and product, but it has already been different depending on which GHC/base version containers is compiled with. So this change makes it consistent.

@phadej
Copy link
Contributor Author

phadej commented Dec 11, 2022

Ah, there's already #880

@phadej phadej closed this Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant