Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Handlebars Copyright Header Comment Format #29890

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

zofskeez
Copy link
Contributor

Description

In this PR for the copywrite tool a ~ was added to comments in .hbs files for whitespace control. That update was reverted due to some noise in the build output complaining about the format:

unexpectedly found "\n  Copyright (c) HashiCorp, Inc.\n  SPDX-License-Identifier: BUSL-1.1\n~" when slicing source, but expected "\n  Copyright (c) HashiCorp, Inc.\n  SPDX-License-Identifier: BUSL-1.1\n"

The copywrite tool has not been run on Vault UI since prior to the removal of the ~ so this PR updates the comments to the latest format.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@zofskeez zofskeez added this to the 1.20.0-rc milestone Mar 10, 2025
@zofskeez zofskeez requested a review from a team as a code owner March 10, 2025 21:33
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 10, 2025
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@zofskeez zofskeez changed the title updates copyright header formatting in hbs files [UI] Handlebars Copyright Header Comment Format Mar 10, 2025
@zofskeez zofskeez merged commit df843a8 into main Mar 11, 2025
45 checks passed
@zofskeez zofskeez deleted the ui/hackweek/copyright-headers-hbs branch March 11, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants