remove hashicorp-forge/bbolt and replace with official beta release #28916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
raskchanky
added a commit
that referenced
this pull request
Nov 19, 2024
…28916) * remove hashicorp-forge/bbolt and replace with official beta release * get rid of redundant method * go mod tidy * make proto
6 tasks
raskchanky
added a commit
that referenced
this pull request
Nov 20, 2024
#28963) * remove hashicorp-forge/bbolt and replace with official beta release (#28916) * remove hashicorp-forge/bbolt and replace with official beta release * get rid of redundant method * go mod tidy * make proto * Update to Go 1.23.3 (#28920) * Update to Go 1.23.3 - Update to latest major version of Go 1.23.3 from 1.22.8. - Update github.com/sasha-s/go-deadlock to address deadlock timer issue we were seeing. - Fix one of our tests to only reset the member variable we change instead of the entire Opts parameter to avoid a data race during testing. * Add workaround for MSSQL TLS certificate container issue * rename go version changelog --------- Co-authored-by: Steven Clark <[email protected]>
Monkeychip
pushed a commit
that referenced
this pull request
Nov 27, 2024
…28916) * remove hashicorp-forge/bbolt and replace with official beta release * get rid of redundant method * go mod tidy * make proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes our dependence on
hashicorp-forge/bboltand replaces it with the officialetcd-io/bbolt. Note that the fix in question, which we created thehashicorp-forge/bboltfor in the beginning, will be part of the 1.4.0 release, not part of the 1.3.x release that we currently use. That fix is here if people are interested.v1.4.0-beta.0is the latest tag currently available.I'm guessing we want to move off the beta tag once a stable tag has been cut but given the pace at which bbolt cuts releases, that might not be for awhile, and the move off of hashicorp-forge/bbolt needs to happen in the next few weeks for compliance reasons.
I ran
go mod tidyandmake protobecause CI told me they needed to be run.TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.