Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VAULT-31754] Check removed status in sys/unseal and error out if the node has been removed from the cluster #28909

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

kubawi
Copy link
Contributor

@kubawi kubawi commented Nov 14, 2024

Description

This PR adds a check for whether the node was removed from a cluster in the handler for /sys/unseal.
If the node was indeed removed, we will respond with a status code 500 and an error saying node was removed from a HA cluster.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@kubawi kubawi self-assigned this Nov 14, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 14, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

@kubawi kubawi added this to the 1.19.0-rc milestone Nov 14, 2024
@kubawi kubawi added core Issues and Pull-Requests specific to Vault Core core/ha specific to high-availability pr/no-changelog labels Nov 14, 2024
@kubawi kubawi marked this pull request as ready for review November 14, 2024 12:34
Copy link
Contributor

@miagilepner miagilepner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Build Results:
All builds succeeded! ✅

@kubawi kubawi merged commit d211f47 into main Nov 14, 2024
146 of 150 checks passed
@kubawi kubawi deleted the kubawi/VAULT-31754/check-removed-status-in-sys-unseal branch November 14, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core/ha specific to high-availability core Issues and Pull-Requests specific to Vault Core hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants