-
Notifications
You must be signed in to change notification settings - Fork 137
Add API Documentation for Multi-Team Tokens #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add API Documentation for Multi-Team Tokens #875
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
101ca21
to
a89b19a
Compare
@@ -1,7 +1,7 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than creating a brand new page for the new API, I decided to break the existing team token API documentation into two sections: "Team tokens API reference" and "Legacy team tokens API reference." Since both APIs will exist simultaneously, I didn't want to make the API tokens site navigation confusing, break existing references to this documentation, or create confusion for users who regularly use these docs. Furthermore, both the old and new API share a lot of the same background information and keeping the two coupled and reusing some of that information felt like the more straightforward thing to do. This all being said, though, I don't feel strongly about coupling or decoupling the two APIs and would love to hear what other folks think!
1dcb277
to
04b3595
Compare
04b3595
to
3aa2f3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions.
Team API tokens grant access to a team's workspaces. Each team can have an API token that is not associated with a specific user. You can create and delete team tokens and list an organization's team tokens. | ||
Team API tokens grant access to a team's workspaces. Teams are not limited to a single token, and can have multiple, valid tokens at a time. Team tokens are not are not associated with a specific user. | ||
|
||
Teams relying on the [**legacy**](/terraform/cloud-docs/api-docs/team-tokens#legacy-team-tokens-api-reference) team token API (`/teams/authentication-token`), can only have a **single**, valid token at a time. Generating a new legacy token revokes any previously existing tokens, replacing it with the new team token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teams relying on the [**legacy**](/terraform/cloud-docs/api-docs/team-tokens#legacy-team-tokens-api-reference) team token API (`/teams/authentication-token`), can only have a **single**, valid token at a time. Generating a new legacy token revokes any previously existing tokens, replacing it with the new team token. | |
Teams relying on the [**legacy**](/terraform/cloud-docs/api-docs/team-tokens#legacy-team-tokens-api-reference) team token API (`/teams/authentication-token`), can only have a **single**, valid token at a time. Generating a new legacy token revokes any previously existing tokens, replacing it with the new team token. |
Does "revokes any previously existing tokens" include tokens under the /teams/:team_id/authentication-tokens
endpoint, or just the legacy endpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the legacy endpoint!
b15dc67
to
18dbeba
Compare
18dbeba
to
190eb3e
Compare
190eb3e
to
919ae1a
Compare
What
Update the Team Token API documentation to reflect the changes to team tokens, which include allowing multiple team tokens to be generated for a team and flagging the existing Team Token API as "legacy."
Why
These updates are relevant to the work being done for the allowance of multiple team tokens. The work being done adds a new API endpoint for creating multiple team tokens and now requires that Team Tokens (using the new API) set a description for the token, similar to the user experience when creating User Tokens. The existing Team Token API that only allows a single team token to be created will still exist so that users leveraging that API do not have to worry about data loss, however, this API is considered to be "legacy" now. Additionally, the work being done includes changes to the regenerate token button in the UI--this button will cease to exist once the changes are rolled out. The API documentation does not mention this button much, so very small wording tweaks were made to reflect this. Here's a link to the RFC for more information regarding the updates, and the Jira ticket for the work.
Merge Checklist
If items do not apply to your changes, add (N/A) and mark them as complete.
Pull Request
Content
website/redirects.js
for moved, renamed, or deleted pages.Reviews