Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarifying details for private module registry version attribute commit-sha #848

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tism
Copy link

@tism tism commented Mar 7, 2025

What

Update the default and description for the commit-sha attribute when creating a non-VCS connected private registry module version

Why

Clarifies what is needed by the API

Screenshots

N/A


Merge Checklist

If items do not apply to your changes, add (N/A) and mark them as complete.

Pull Request

  • One or more labels describe the type of change (e.g. clarification) and associated product (e.g. HCP Terraform ).
  • Description links to related pull requests or issues, if any.

Content

  • Redirects have been added to website/redirects.js for moved, renamed, or deleted pages. (N/A)
  • API documentation and the API Changelog have been updated. (N/A)
  • Links to related content where appropriate (e.g., API endpoints, permissions, etc.). (N/A)
  • Pages with related content are updated and link to this content when appropriate. (N/A)
  • Sidebar navigation files have been updated for added, deleted, reordered, or renamed pages. (N/A)
  • New pages have metadata (page name and description) at the top. (N/A)
  • New images are 2048 px wide. They have HashiCorp standard annotation color (#F92672) and format (rectangle with rounded corners), blurred sensitive details (e.g. credentials, usernames, user icons), and descriptive alt text in the markdown for accessibility. (N/A)
  • New code blocks have the correct syntax and line breaks to eliminate horizontal scroll bars. (N/A)
  • UI elements (button names, page names, etc.) are bolded. (N/A)
  • The Vercel website preview successfully deployed.

Reviews

  • I or someone else reviewed the content for technical accuracy.
  • I or someone else reviewed the content for typos, punctuation, spelling, and grammar.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tism tism added documentation Improvements or additions to documentation clarification labels Mar 7, 2025
Copy link

vercel bot commented Mar 7, 2025

@tism is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

@tism tism changed the title Add default for commit-sha Add clarifying details for private module registry version attribute commit-sha Mar 7, 2025
@tism tism requested a review from a team March 11, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant