Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] - Makefile - change sed expression to be cross platform #4783

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mur-me
Copy link
Collaborator

@mur-me mur-me commented Oct 25, 2024

Issue

Makefile - change sed expression to be cross platform, because Macos has sed openbsd version and linux has GNU one, add git restore for the localnet configs on the explicit debug-kill

Tested on the Linux and Mac

$ make debug-ext and grep localnetBlocks internal/configs/sharding/localnet.go

	localnetBlocksPerEpoch = 64
	localnetBlocksPerEpochV2 = 64

$ make debug-kill and grep localnetBlocks internal/configs/sharding/localnet.go

        localnetBlocksPerEpoch   = 16
        localnetBlocksPerEpochV2 = 16

Before:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

After:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

Test/Run Logs

Operational Checklist

  1. Does this PR introduce backward-incompatible changes to the on-disk data structure and/or the over-the-wire protocol?. (If no, skip to question 8.)

    YES|NO

  2. Describe the migration plan.. For each flag epoch, describe what changes take place at the flag epoch, the anticipated interactions between upgraded/non-upgraded nodes, and any special operational considerations for the migration.

  3. Describe how the plan was tested.

  4. How much minimum baking period after the last flag epoch should we allow on Pangaea before promotion onto mainnet?

  5. What are the planned flag epoch numbers and their ETAs on Pangaea?

  6. What are the planned flag epoch numbers and their ETAs on mainnet?

    Note that this must be enough to cover baking period on Pangaea.

  7. What should node operators know about this planned change?

  8. Does this PR introduce backward-incompatible changes NOT related to on-disk data structure and/or over-the-wire protocol? (If no, continue to question 11.)

    YES|NO

  9. Does the existing node.sh continue to work with this change?

  10. What should node operators know about this change?

  11. Does this PR introduce significant changes to the operational requirements of the node software, such as >20% increase in CPU, memory, and/or disk usage?

TODO

…e Macos has sed openbsd version and linux has GNU one, add git restore for the localnet configs on the explicit debug-kill
@sophoah
Copy link
Contributor

sophoah commented Oct 28, 2024

@Frozen this one is for you, please test and approve if the change works for you.

@Frozen
Copy link
Contributor

Frozen commented Oct 28, 2024

# after make debug-ext 
% grep localnetBlocks internal/configs/sharding/localnet.go


        localnetBlocksPerEpoch   = 16
        localnetBlocksPerEpochV2 = 16
        return localnetBlocksPerEpoch
        return localnetBlocksPerEpochV2

@sophoah
Copy link
Contributor

sophoah commented Nov 13, 2024

@mur-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants