Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Early return from finalCommit to prevent processing with empty hash. #4778

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Early return from finalCommit to prevent processing with empty hash. #4778

wants to merge 1 commit into from

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented Oct 22, 2024

StagedStreamSync::doSync calls finishSyncing which internally calls reset on consensus. finalCommitruns in goroutine, so it receives empty hash after reset.

@sophoah
Copy link
Contributor

sophoah commented Oct 23, 2024 •
edited
Loading

We can't merged that PR. It will impact the validator signature received after the quorum is met

@Frozen Frozen added the WIP Work in progress don't merge yet! label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP Work in progress don't merge yet!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Frozen @sophoah