task 6 #74
Open
task 6 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSus
force-pushed
the
task6
branch
2 times, most recently
from
c4df34f to
9ebfc71
Compare
spajic
approved these changes
Feb 22, 2022
| - name: js budget check | ||
| uses: docker://sitespeedio/sitespeed.io:latest | ||
| with: | ||
| args: https://8b1b-2a02-a310-c25a-f500-a479-5be6-50d3-1088.ngrok.io -n 1 --budget.configPath ./budget.json |
There was a problem hiding this comment.
Плюсую всё latest, github ci и ngrok 👍
| Failing budget JavaScript Transfer Size for http://host.docker.internal:3000/ with value 521.9 KB max limit 459.0 KB | ||
| ``` | ||
|
|
||
| объем js сильно уменьшился но в бюджеты еще не влазит (но близко) |
There was a problem hiding this comment.
со временем npm-пакеты разбухли наверно, раньше влезало
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?