Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week 5 - Alexander Belozerov (sashabelozerov) #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Week 5 - Alexander Belozerov (sashabelozerov) #88

wants to merge 2 commits into from

Conversation

sashabelozerov
Copy link

[x] Реализация server-push для указанных в задании картинок
[x] Конфиг NGinx
[x] Ссылка на сравнение HAR-файлов с server-push и без
[ ] Бонус 1 про dev.to
[ ] Бонус 2 про Falcon

Re:

Сравните два полученных HAR-файла с помощью https://compare.sitespeed.io/
Обязательно добавьте ссылку на сравнение в описание PR

К сожалению, не нашел в интерфейсе Sitespeed возможность сгенерировать такую ссылку.
Скриншоты Waterfall:

Screenshot 2022-06-06 at 17 47 51

Screenshot 2022-06-06 at 17 48 13

spajic
spajic approved these changes Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@spajic spajic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ approve, мне нечего особо добавить

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spajic spajic spajic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sashabelozerov @spajic