-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize task 4 #148
Open
iris-the-fox
wants to merge
1
commit into
hardcode-dev:master
Choose a base branch
from
iris-the-fox:optmization-task-4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
optimize task 4 #148
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# Case-study оптимизации | ||
|
||
ApacheBench: | ||
``` | ||
Concurrency Level: 5 | ||
Time taken for tests: 47.600 seconds | ||
Complete requests: 100 | ||
Failed requests: 0 | ||
Total transferred: 15984100 bytes | ||
HTML transferred: 15937400 bytes | ||
Requests per second: 2.10 [#/sec] (mean) | ||
Time per request: 2380.021 [ms] (mean) | ||
Time per request: 476.004 [ms] (mean, across all concurrent requests) | ||
Transfer rate: 327.93 [Kbytes/sec] received | ||
|
||
``` | ||
В задаче имеется подсказка, что заметное время занимает рендеринг partial-ов single_story.html.erb. Однако я этого не увидела | ||
|
||
**rack-mini-profiler** показывает первую загрузку страницы за 7480ms, повторные же в пределах 700ms из-за встроенных кэшей | ||
Наибольшее время (2250ms) `articles/_sidebar.html.erb` | ||
|
||
**New Relic** | ||
Web transactions time - 2600ms из них ruby занимает 2008ms. | ||
most time consuming - stories#index | ||
stories#index - 790ms | ||
layouts/application.html.erb - 624ms | ||
single_story.html.erb - 206ms | ||
articles/sidebar.html.erb - 120ms | ||
|
||
Я закэшировала single_story, тогда | ||
ApacheBench | ||
``` | ||
Requests per second: 7.16 [#/sec] (mean) | ||
Time per request: 698.126 [ms] (mean) | ||
Time per request: 139.625 [ms] (mean, across all concurrent requests) | ||
Transfer rate: 1121.84 [Kbytes/sec] received | ||
``` | ||
|
||
**rack-mini-profiler** показывает время загрузки 350ms | ||
Время загрузки по **NewRelic** тоже уменьшилось, см скриншот. | ||
Но почему это работает - я не понимаю, ведь single_story не выглядела как основная точка роста. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
по идее это на самом деле так, возможно надо побольше/подольше поделать запросов, чтобы это увидеть в NewRelic