Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Домашнее задание №3 (Лисичкин Дмитрий) #99

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

Tab10id
Copy link

@Tab10id Tab10id commented Apr 4, 2023

No description provided.

Copy link
Collaborator

@spajic spajic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень круто, одна из лучших работ за всё время 👍 👍

@@ -24,3 +24,10 @@ end

# Windows does not include zoneinfo files, so bundle the tzinfo-data gem
gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]

gem 'perfolab', github: 'Tab10id/perfolab', branch: :temp_26
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

</ul>
<%= render "delimiter" %>
<% end %>
<%= render partial: 'trip', collection: @trips, spacer_template: 'delimiter' %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Идеально

## Основные проблемы на начальном этапе

* Отсутствие тестов.
* Нет возможности проводить оптимизацию без опасения что-либо сломать.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

attr_reader :file_name, :batch_size
BusesService = Class.new(ActiveRecord::Base)

class TripsJsonStreamHandler < ::Oj::ScHandler
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants