Task3 #4
Closed
Task3 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spajic
reviewed
Sep 23, 2019
| <% services.each do |service| %> | ||
| <%= render "service", service: service %> | ||
| <% end %> | ||
| <%= render partial: "service", collection: services %> |
There was a problem hiding this comment.
👍 Частенько просто удаляют partial-ы и лепят всё в один файл
spajic
reviewed
Sep 23, 2019
| <li><%= "В пути: #{trip.duration_minutes / 60}ч. #{trip.duration_minutes % 60}мин." %></li> | ||
| <li><%= "Цена: #{trip.price_cents / 100}р. #{trip.price_cents % 100}коп." %></li> | ||
| <li><%= "Автобус: #{trip.bus.model} №#{trip.bus.number}" %></li> | ||
| <% cache trip do %> |
spajic
reviewed
Sep 23, 2019
| # explain запросов и добавление индексов | ||
|
|
||
| Изучив запросы к бд, я добавил несколько индексов, в том числе составной индекс для trips -> | ||
| [:from_id, :to_id, :start_time], что значительно ускорило выборку данных из базы. |
There was a problem hiding this comment.
👍 Идеально было бы ещё привести планы запросов до и после добавления индекса
spajic
reviewed
Sep 23, 2019
| # Итог | ||
|
|
||
| После всех оптимизаций удалось добиться открытия заполненной из large.json страницы менее чем за | ||
| 0.5 секунды, по сравнению с первонатальным кодом страница ускорилась примерно в 150 раз |
spajic
reviewed
Sep 23, 2019
| def change | ||
| add_index(:buses_services, :bus_id) | ||
| add_index(:cities, :name) | ||
| add_index(:trips, :from_id) |
There was a problem hiding this comment.
Этот индекс получается лишний, если есть составной на [:from_id, :to_id, :start_time]
spajic
reviewed
Sep 23, 2019
| @@ -0,0 +1,96 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class JsonFileToDbProcessor | |||
There was a problem hiding this comment.
👍 Плюсик за вынос в отдельный файл
spajic
approved these changes
Sep 23, 2019
otmosina
added a commit
to otmosina/rails-optimization-task3
that referenced
this pull request
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.