Task #3 [Oleynik] #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 28, 2020 22:02
spajic
approved these changes
Aug 4, 2020
| </h2> | ||
|
|
||
| <% @trips.each do |trip| %> | ||
| <ul> | ||
| <%= render "trip", trip: trip %> | ||
| <li><%= "Отправление: #{trip.start_time}" %></li> |
There was a problem hiding this comment.
Так быстрее, но с другой стороны вроде бы почище смотрится этот partial в отдельном файле
Можно было бы попробовать оставить partial, но рендерить не в цикле, а коллекцией
|
|
||
| config.after_initialize do | ||
| Bullet.enable = true | ||
| Bullet.add_footer = true |
| @@ -2,4 +2,6 @@ | |||
| # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html | |||
| get "/" => "statistics#index" | |||
| get "автобусы/:from/:to" => "trips#index" | |||
|
|
|||
| mount PgHero::Engine, at: "pghero" | |||
| t.integer "service_id" | ||
| t.string "bus_id" | ||
| t.string "service_id" | ||
| t.index ["bus_id", "service_id"], name: "index_buses_services_on_bus_id_and_service_id" |
There was a problem hiding this comment.
👍 плюсик за составной индекс
| t.string "start_time" | ||
| t.integer "duration_minutes" | ||
| t.integer "price_cents" | ||
| t.integer "bus_id" | ||
| t.index ["from_id", "to_id"], name: "index_trips_on_from_id_and_to_id" |
| @@ -34,12 +37,13 @@ | |||
| end | |||
|
|
|||
| create_table "trips", force: :cascade do |t| | |||
| t.integer "from_id" | |||
| t.integer "to_id" | |||
| t.string "from_id" | |||
There was a problem hiding this comment.
А зачем на строку поменяли?
| @@ -1,34 +1,68 @@ | |||
| # Наивная загрузка данных из json-файла в БД | |||
| # frozen_string_literal: true | |||
There was a problem hiding this comment.
Удобнее было бы работать, вынеся логику из rake-таски в ruby-класс
| Rake::Task.define_task(:environment) | ||
| end | ||
|
|
||
| it 'выполняется без ошибок' do |
| #### Находка 5 | ||
| - PGHero показал точку роста при запросе маршрутов. | ||
| - Добавил индекс на атрибуты по которому производится поиск `[:from_id, :to_id]` в таблицу `trips`. | ||
| - Эта точка роста не находилась выше всех и осталась на своем месте, но время обращения к базе снизилось - до *50ms*. |
There was a problem hiding this comment.
Всячески поддерживаю облегчение жизни БД с помощью ускорения запросов и плюсик за составной индекс 👍
Но тут видно, что на общем фоне рендеринга страницы за 3000ms прирост в 15ms погоды не делает
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.