Task-3 #22
Open
Task-3 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spajic
approved these changes
Feb 26, 2020
| Service.delete_all | ||
| Trip.delete_all | ||
| ActiveRecord::Base.connection.execute("delete from buses_services;") | ||
| ActiveRecord::Base.connection.reset_pk_sequence!("cities") |
There was a problem hiding this comment.
👍 плюсик за ресет sequence
app/services/import_data.rb
Outdated
| private | ||
|
|
||
| def parse_id(dict, hash_key) | ||
| to_id = send(dict)[hash_key] |
There was a problem hiding this comment.
Странно, что вы передаёте символ и потом делаете send
Можно просто передавать сам хэш
| to_id = parse_id(:cities, trip["to"]) | ||
| bus = bus_number(trip["bus"]) | ||
|
|
||
| # стримим подготовленный чанк данных в postgres |
| <% services.each do |service| %> | ||
| <%= render "service", service: service %> | ||
| <% end %> | ||
| <%= render partial: "service", collection: services %> |
There was a problem hiding this comment.
Плюсик за рендеринг коллекции.
Многие просто удаляют паршлы и копипастят их контент в шаблон
app/views/trips/_trip.html.erb
Outdated
| <li><%= "В пути: #{trip.duration_minutes / 60}ч. #{trip.duration_minutes % 60}мин." %></li> | ||
| <li><%= "Цена: #{trip.price_cents / 100}р. #{trip.price_cents % 100}коп." %></li> | ||
| <li><%= "Автобус: #{trip.bus.model} №#{trip.bus.number}" %></li> | ||
| <% cache trip do %> |
There was a problem hiding this comment.
Полезность кэширования тут под вопросом.
На странице много трипов, и за каждым надо сходить в Redis.
Кажется, что рендерить их не особо медленнее, но чтобы сказать точно надо бенчмаркать.
| </ul> | ||
| <%= render "delimiter" %> | ||
| <% end %> | ||
| <%= render partial: "trip", collection: @trips, spacer_template: 'delimiter' %> |
There was a problem hiding this comment.
Плюсик за spacer_template!
| @@ -0,0 +1,5 @@ | |||
| class IndexForeignKeysInBusesServices < ActiveRecord::Migration[5.2] | |||
| def change | |||
| add_index :buses_services, [:bus_id, :service_id] | |||
There was a problem hiding this comment.
В данном случае не важно, но на проде лучше всегда использовать concurrently
| @@ -0,0 +1,38 @@ | |||
| [ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача 1
Задача 2
Пробовал профилировать всеми инструментами, что показывались на уроке.