Valeev dz3 #21
Open
Valeev dz3 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruvaleev
commented
Feb 23, 2020
ruvaleev
commented
spajic
approved these changes
Feb 26, 2020
| @@ -7,6 +7,15 @@ gem 'rails', '~> 5.2.3' | |||
| gem 'pg', '>= 0.18', '< 2.0' | |||
| gem 'puma', '~> 3.11' | |||
| gem 'bootsnap', '>= 1.1.0', require: false | |||
| gem 'newrelic_rpm' | |||
| gem 'pghero' | |||
| gem 'badger-rails' | |||
| @@ -0,0 +1,84 @@ | |||
| class ReloadJson | |||
There was a problem hiding this comment.
Хорошо, что вынесли в отдельный сервис, но название непонятное
| @@ -0,0 +1,84 @@ | |||
| class ReloadJson | |||
| def call(file_name, without_db_queries = false) | |||
| json = JSON.parse(File.read(file_name)) | |||
There was a problem hiding this comment.
Грузим потенциально большой JSON сразу весь в память -> bloat
| @@ -2,15 +2,24 @@ | |||
| <%= "Автобусы #{@from.name} – #{@to.name}" %> | |||
| </h1> | |||
| <h2> | |||
| <%= "В расписании #{@trips.count} рейсов" %> | |||
| <%= "В расписании #{@trips.load.size} рейсов" %> | |||
There was a problem hiding this comment.
👍 👍 Вы первый, кто сделал load.size, хотя именно так и было в лекции
| После первой итерации (только Trips завернули в import) | ||
| Finish in 116.12 | ||
|
|
||
| ### Защитимся от внесения функциональных ошибок тестом test/services/reload_json_spec.rb |
|
|
||
| Вдобавок ко всему, сделаем это, отказавщись от хэшей, используя только массивы (за исключением json-а) | ||
|
|
||
| Результат оказался очень впечатляющим. |
| ### Седьмая гипотеза | ||
| #### Убрать все вычисления во вьюхе trips/index.html.erb | ||
|
|
||
| Никакого профита, первый раз страница загрузилась даже за 9+ секунд. Так что геморрой с костылями и колбэками себя не оправдывает. |
There was a problem hiding this comment.
Хорошо, что решили оценить перед тем как делать!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.