ДЗ 3 #20
Open
ДЗ 3 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spajic
approved these changes
Feb 26, 2020
|
|
||
| class UploadData | ||
| def self.call(file_name) | ||
| json = JSON.parse(File.read(file_name)) |
There was a problem hiding this comment.
Грузим в память весь json, который может быть большим
Плюс можно выиграть за счёт Oj
| uploaded_services = Service.all.inject({}) { |acc, elem| acc.merge!(elem.name => elem.id) } | ||
| # uploaded_services == {"Ремни безопасности"=> Service, ...} | ||
|
|
||
| cities = Set.new |
There was a problem hiding this comment.
Кажется не очень хорошая идея здесь использовать Set
Так как Set позволяет хранить только уникальные объекты, ему надо постоянно сравнивать cities, которые сами по себе являются хэшами.
| # save to DB | ||
| result = City.import(cities.to_a, returning: [:id, :name]) | ||
| uploaded_cities = result.results.inject({}) { |acc, elem| acc.merge!(elem[1] => elem[0]) } | ||
| # uploaded_cities == {"Сочи"=>1, "Тула"=>2, "Самара"=>3, "Красноярск"=>4, "Волгоград"=>5, "Рыбинск"=>6, "Саратов"=>7, "Москва"=>8, "Ярославль"=>9, "Ростов"=>10} |
There was a problem hiding this comment.
👍 Плюс за коммент, без него было бы сложновато понять что получается
| @@ -2,15 +2,24 @@ | |||
| <%= "Автобусы #{@from.name} – #{@to.name}" %> | |||
| </h1> | |||
| <h2> | |||
| <%= "В расписании #{@trips.count} рейсов" %> | |||
| <%= "В расписании #{@trips.size} рейсов" %> | |||
|
|
||
| ## Находка 1 | ||
| Раздумия над алгоритмом загрузки показали, что: | ||
| - должно быть слишком много запросов на создание/поиск городов, т.к. их всего 10, то проще и быстрее создать их за 1 прозод через файл, сформировать список загруженных и затем использовать его вместо постоянного обращения к БД |
| - при третьем проходе формируются маршруты | ||
| - результат | ||
| - medium файл стал загружаться за 7 секнуд | ||
| - large - 23 секунды |
| - время импорта large данных - 19 секунд | ||
| - рендеринг страницы | ||
| Rendered trips/index.html.erb within layouts/application (705.2ms) | ||
| Completed 200 OK in 717ms (Views: 702.6ms | ActiveRecord: 12.0ms) |
| - использовалось | ||
| - [x] `bullet` | ||
| - [x] `pghero` | ||
| - здравый смысл и опыт |
|
|
||
| def change | ||
| add_index :trips, [:from_id, :to_id], algorithm: :concurrently | ||
| add_index :buses_services, [:bus_id, :service_id], algorithm: :concurrently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.