[#3] Optimization of trips import and trips view

.gitignore

@@ -2,3 +2,4 @@
 /tmp
 /log
 /public
+.byebug_history

.rspec

@@ -0,0 +1 @@
+--require spec_helper

.rubocop.yml

@@ -0,0 +1,15 @@
+require:
+  - rubocop-performance
+  - rubocop-rspec
+  - standard/cop/semantic_blocks
+
+inherit_mode:
+  merge:
+    - Exclude
+
+inherit_gem:
+  standard: config/base.yml
+
+AllCops:
+  Exclude:
+    - 'bin/**'

Gemfile

@@ -1,26 +1,44 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
-ruby '2.6.3'
+ruby "2.6.3"
 
-gem 'rails', '~> 5.2.3'
-gem 'pg', '>= 0.18', '< 2.0'
-gem 'puma', '~> 3.11'
-gem 'bootsnap', '>= 1.1.0', require: false
+gem "rails", "~> 5.2.3"
+gem "pg", ">= 0.18", "< 2.0"
+gem "puma", "~> 3.11"
+gem "bootsnap", ">= 1.1.0", require: false
+gem "activerecord-import"
+gem "json-streamer"
+gem "dry-container"
+gem "redis"
 
 group :development, :test do
+  gem "rubocop"
+  gem "rubocop-performance"
+  gem "rubocop-rspec"
+  gem "standard", "0.1.7"
+
   # Call 'byebug' anywhere in the code to stop execution and get a debugger console
-  gem 'byebug', platforms: [:mri, :mingw, :x64_mingw]
+  gem "byebug", platforms: [:mri, :mingw, :x64_mingw]
+  gem "ruby-prof"
+  gem "meta_request"
+  gem "rails_panel"
+
+  gem "factory_bot_rails"
+  gem "database_cleaner"
+  gem "rspec-rails"
+  gem "rspec-benchmark"
 end
 
 group :development do
   # Access an interactive console on exception pages or by calling 'console' anywhere in the code.
-  gem 'web-console', '>= 3.3.0'
-  gem 'listen', '>= 3.0.5', '< 3.2'
+  gem "web-console", ">= 3.3.0"
+  gem "listen", ">= 3.0.5", "< 3.2"
 end
 
 group :test do
+  gem "capybara"
 end
 
 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
-gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
+gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw, :jruby]

Gemfile.lock

@@ -33,6 +33,8 @@ GEM
       activemodel (= 5.2.3)
       activesupport (= 5.2.3)
       arel (>= 9.0)
+    activerecord-import (1.0.2)
+      activerecord (>= 3.2)
     activestorage (5.2.3)
       actionpack (= 5.2.3)
       activerecord (= 5.2.3)
@@ -42,20 +44,53 @@ GEM
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
+    addressable (2.6.0)
+      public_suffix (>= 2.0.2, < 4.0)
     arel (9.0.0)
+    ast (2.4.0)
+    benchmark-malloc (0.1.0)
+    benchmark-perf (0.5.0)
+    benchmark-trend (0.3.0)
     bindex (0.6.0)
     bootsnap (1.4.2)
       msgpack (~> 1.0)
     builder (3.2.3)
     byebug (11.0.1)
+    capybara (3.20.2)
+      addressable
+      mini_mime (>= 0.1.3)
+      nokogiri (~> 1.8)
+      rack (>= 1.6.0)
+      rack-test (>= 0.6.3)
+      regexp_parser (~> 1.2)
+      xpath (~> 3.2)
     concurrent-ruby (1.1.5)
     crass (1.0.4)
+    database_cleaner (1.7.0)
+    diff-lcs (1.3)
+    dry-configurable (0.8.3)
+      concurrent-ruby (~> 1.0)
+      dry-core (~> 0.4, >= 0.4.7)
+    dry-container (0.7.2)
+      concurrent-ruby (~> 1.0)
+      dry-configurable (~> 0.1, >= 0.1.3)
+    dry-core (0.4.8)
+      concurrent-ruby (~> 1.0)
     erubi (1.8.0)
+    factory_bot (5.1.1)
+      activesupport (>= 4.2.0)
+    factory_bot_rails (5.1.1)
+      factory_bot (~> 5.1.0)
+      railties (>= 4.2.0)
     ffi (1.10.0)
     globalid (0.4.2)
       activesupport (>= 4.2.0)
     i18n (1.6.0)
       concurrent-ruby (~> 1.0)
+    jaro_winkler (1.5.4)
+    json-stream (0.2.1)
+    json-streamer (2.1.0)
+      json-stream
     listen (3.1.5)
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
@@ -67,6 +102,9 @@ GEM
       mini_mime (>= 0.1.1)
     marcel (0.3.3)
       mimemagic (~> 0.3.2)
+    meta_request (0.7.2)
+      rack-contrib (>= 1.1, < 3)
+      railties (>= 3.0.0, < 7)
     method_source (0.9.2)
     mimemagic (0.3.3)
     mini_mime (1.0.1)
@@ -76,9 +114,15 @@ GEM
     nio4r (2.3.1)
     nokogiri (1.10.2)
       mini_portile2 (~> 2.4.0)
+    parallel (1.19.1)
+    parser (2.7.0.2)
+      ast (~> 2.4.0)
     pg (1.1.4)
+    public_suffix (3.1.1)
     puma (3.12.1)
     rack (2.0.6)
+    rack-contrib (2.1.0)
+      rack (~> 2.0)
     rack-test (1.1.0)
       rack (>= 1.0, < 3)
     rails (5.2.3)
@@ -99,16 +143,59 @@ GEM
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.0.4)
       loofah (~> 2.2, >= 2.2.2)
+    rails_panel (0.0.1)
     railties (5.2.3)
       actionpack (= 5.2.3)
       activesupport (= 5.2.3)
       method_source
       rake (>= 0.8.7)
       thor (>= 0.19.0, < 2.0)
+    rainbow (3.0.0)
     rake (12.3.2)
     rb-fsevent (0.10.3)
     rb-inotify (0.10.0)
       ffi (~> 1.0)
+    redis (4.1.0)
+    regexp_parser (1.5.1)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-benchmark (0.5.1)
+      benchmark-malloc (~> 0.1.0)
+      benchmark-perf (~> 0.5.0)
+      benchmark-trend (~> 0.3.0)
+      rspec (>= 3.0.0, < 4.0.0)
+    rspec-core (3.9.1)
+      rspec-support (~> 3.9.1)
+    rspec-expectations (3.9.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-rails (3.9.0)
+      actionpack (>= 3.0)
+      activesupport (>= 3.0)
+      railties (>= 3.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.2)
+    rubocop (0.77.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.6)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    rubocop-performance (1.5.2)
+      rubocop (>= 0.71.0)
+    rubocop-rspec (1.38.1)
+      rubocop (>= 0.68.1)
+    ruby-prof (1.2.0)
+    ruby-progressbar (1.10.1)
     ruby_dep (1.5.0)
     sprockets (3.7.2)
       concurrent-ruby (~> 1.0)
@@ -117,10 +204,14 @@ GEM
       actionpack (>= 4.0)
       activesupport (>= 4.0)
       sprockets (>= 3.0.0)
+    standard (0.1.7)
+      rubocop (~> 0.77.0)
+      rubocop-performance (~> 1.5.1)
     thor (0.20.3)
     thread_safe (0.3.6)
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
+    unicode-display_width (1.6.1)
     web-console (3.7.0)
       actionview (>= 5.0)
       activemodel (>= 5.0)
@@ -129,17 +220,35 @@ GEM
     websocket-driver (0.7.0)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.3)
+    xpath (3.2.0)
+      nokogiri (~> 1.8)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  activerecord-import
   bootsnap (>= 1.1.0)
   byebug
+  capybara
+  database_cleaner
+  dry-container
+  factory_bot_rails
+  json-streamer
   listen (>= 3.0.5, < 3.2)
+  meta_request
   pg (>= 0.18, < 2.0)
   puma (~> 3.11)
   rails (~> 5.2.3)
+  rails_panel
+  redis
+  rspec-benchmark
+  rspec-rails
+  rubocop
+  rubocop-performance
+  rubocop-rspec
+  ruby-prof
+  standard (= 0.1.7)
   tzinfo-data
   web-console (>= 3.3.0)
 

Rakefile

@@ -1,6 +1,6 @@
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require_relative 'config/application'
+require_relative "config/application"
 
 Rails.application.load_tasks

app/containers/trips_container.rb

@@ -0,0 +1,10 @@
+class TripsContainer
+  extend Dry::Container::Mixin
+
+  register("import") do
+    Trips::Import.new(
+      Utils::TruncateTables.new,
+      BusServices::Seed.new
+    )
+  end
+end

app/controllers/trips_controller.rb

@@ -1,7 +1,34 @@
 class TripsController < ApplicationController
+  helper_method :index_html
+
   def index
-    @from = City.find_by_name!(params[:from])
-    @to = City.find_by_name!(params[:to])
-    @trips = Trip.where(from: @from, to: @to).order(:start_time)
+    if index_cache.nil?
+      @from = City.find_by_name!(params[:from])
+      @to = City.find_by_name!(params[:to])
+      @trips = Trip.where(from: @from, to: @to).includes(bus: :services).order(:start_time)
+
+      prepare_index_cache
+    end
+  end
+
+  private
+
+  def index_cache
+    @index_cache ||= Redis.current.get("TripsController#index_#{params[:from].downcase}_#{params[:to].downcase}")
+  end
+
+  def index_html
+    @index_html ||=
+      index_cache || render_to_string(
+        "trips/_index",
+        locals: {:@from => @from, :@to => @to, :@trips => @trips}
+      )
+  end
+
+  def prepare_index_cache
+    Redis.current.set(
+      "TripsController#index_#{params[:from].downcase}_#{params[:to].downcase}",
+      index_html, ex: 1.minutes
+    )
   end
 end

app/lib/bus_services/seed.rb

@@ -0,0 +1,27 @@
+module BusServices
+  class Seed
+    def call
+      columns = [:id, :name]
+      import_data = Service::SERVICES.each_with_index.map { |v, i|
+        [i + 1, v]
+      }
+
+      Service.import(columns, import_data)
+
+      # Result of insertion in format:
+      # {
+      #   "WiFi" => 1,
+      #   "Туалет" => 2,
+      #   "Работающий туалет" => 3,
+      #   "Ремни безопасности" => 4,
+      #   "Кондиционер общий" => 5,
+      #   "Кондиционер Индивидуальный" => 6,
+      #   "Телевизор общий" => 7,
+      #   "Телевизор индивидуальный" => 8,
+      #   "Стюардесса" => 9,
+      #   "Можно не печатать билет" => 10
+      # }
+      Hash[import_data.map { |id, value| [value, id] }]
+    end
+  end
+end