Allow HAPPO_GITHUB_USER_CREDENTIALS to work with async comparisons #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently made some adjstuments that allow for this to work with async comparisons made by Playwright and Cypress. More info: happo/happo-e2e#71 I thin this means that we can also modify this code so it will work with async comparisons produced by this package. While I was in here I also refactored these commands to set `process.exitCode` instead of calling `process.exit()` which can interrupt in-flight asynchronous work including writing to stdout/stderr. Since these are all in the top-level commands, I think returning normally will have the same result for the end user as `process.exit()` would have.
trotzig
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently made some adjstuments that allow for this to work with async comparisons made by Playwright and Cypress. More info:
happo/happo-e2e#71
I thin this means that we can also modify this code so it will work with async comparisons produced by this package.
While I was in here I also refactored these commands to set
process.exitCodeinstead of callingprocess.exit()which can interrupt in-flight asynchronous work including writing to stdout/stderr. Since these are all in the top-level commands, I think returning normally will have the same result for the end user asprocess.exit()would have.