Add Playwright test for invoking param function #141
+9,466
−16,357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trotzig
force-pushed
the
test-playwright
branch
from
801292d to
1622af6
Compare
We want to make sure that the fix in f5fd1c8 doesn't regress. The best idea for a test we could come up with was to use Playwright to load the storybook and verify that the right things happened on click. As part of this change I'm switching us back to yarn 1. While being on newer yarn is generally a good idea, our other repos are all on yarn 1 and it's annoying when switching.
trotzig
force-pushed
the
test-playwright
branch
from
1622af6 to
9d57891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure that the fix in f5fd1c8 doesn't regress. The best idea for a test we could come up with was to use Playwright to load the storybook and verify that the right things happened on click.