Skip to content

[실습] 연습문제 week1/03 제출합니다 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[실습] 연습문제 week1/03 제출합니다 #15

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee4b382
practice: 1주차 4번 문제 제출
minsoo-web Aug 2, 2023
76502b2
Update packages/example/src/1week/04/__submit__/minsoo-web.ts
minsoo-web Aug 10, 2023
5c18bc3
chore: 충일님 리뷰 반영
minsoo-web Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions packages/example/src/1week/04/__submit__/minsoo-web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
export function convertToConditionalUpperCase(words: string[]): string[] {
const capitalized = []

for (let i = 0; i < words.length; i += 1) {
if (words[i].length > 5) {
capitalized.push(words[i].toUpperCase())
} else {
capitalized.push(words[i].toLowerCase())
}
}
const condition = (text: string, criteria = 5) => text.length > criteria
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

condition 함수의 이름이 조금 추상적으로 느껴져서

Suggested change
const condition = (text: string, criteria = 5) => text.length > criteria
const isLongerThanCriteria = (text: string, criteria = 5) => text.length > criteria

is 프리픽스로 boolean임을 더욱 분명하게 알려주는 구체적인 네이밍 isLongerThanCriteria도 좋을 것 같아요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 너무 명확하네요 ㅠㅠ 좋습니다 충일님!! 반영하겠습니다 :)


return capitalized
/**
* 접근 방법:
* 앞선 문제들과 비슷하게, 순수함수를 뽑고,
* map을 활용해서 copy on write 방식을 적용해봤습니다.
*
* @param words 단어들의 배열입니다.
* @returns 컨디션에 맞게 배열의 단어들을 소문자와 대문자의 조합으로 반환해줍니다.
*/
export function convertToConditionalUpperCase(words: string[]): string[] {
return words.map((word) =>
condition(word) ? word.toUpperCase() : word.toLocaleLowerCase(),
)
}