Added Color::LAB and Color::XYZ classes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be happier if you work with @daveheitzman to figure out which bits work well together. I'm a little swamped right now, so I'm not having a lot of time to spend on the design for color 2.0, which is when these classes will be introduced. |
- Remove explicit support for Ruby 1.8 from Travis. - Remove deprecated methods and constant warnings.
…mputing contrast. Added tests for this and existing #contrast
… objects to reflect
Open
|
I am interested in this, but would prefer if you could target this to the changes being made either in |
|
Done. Take a look please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry guys I missed the existing #8 pull request, but anyway think some bits maybe useful.
This should be backward-compatible: previously to_xyz/to_lab returned hash now its LAB and XYZ classes, but they support accessing individual components by square brackets, like hash:
rgb.to_xyz[:x]