Restore classic Join and Merge handlers, make index-based handlers optional #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stempler
approved these changes
Nov 7, 2024
| @@ -21,7 +21,10 @@ | |||
| import java.util.Collections; | |||
| import java.util.List; | |||
|
|
|||
| import de.fhg.igd.slf4jplus.ALogger; | |||
There was a problem hiding this comment.
Build error hints at package import may be missing in manifest?
florianesser
force-pushed
the
perf/join-merge-handler
branch
from
25c894f to
3687be2
Compare
|
hale studio builds for this pull request: Build triggered for commit 8e61992. |
|
/autosquash |
Restore the classes `JoinHandler` and `PropertiesMergeHandler` as the default handlers for the transformation functions Join, Groovy Join, Merge and Groovy Merge. The previous default handlers `IndexJoinHandler` and `IndexMergeHandler` have demonstrated negative impact on the performance of some transformations. Until this is better understood and fixed, these handlers are now optional and can be activated via the following Java properties and environment variables: - Join/Groovy Join: `hale.functions.use_index_join_handler` / `HALE_FUNCTIONS_USE_INDEX_JOIN_HANDLER` - Merge/Groovy Merge: `hale.functions.use_index_merge_handler` / `HALE_FUNCTIONS_USE_INDEX_MERGE_HANDLER` ING-4464
florianesser
force-pushed
the
perf/join-merge-handler
branch
from
3687be2 to
a688c7c
Compare
|
Merging w/o challenge as performance improvement was tested as part of the hale-core PR and verification of the functionality of the new switches is not essential. |
florianesser
added
the
challenged
|
Tested function of |
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionally identical to this hale-core PR
Restore the classes
JoinHandlerandPropertiesMergeHandleras the default handlers for the transformation functions Join, Groovy Join, Merge and Groovy Merge.The previous default handlers
IndexJoinHandlerandIndexMergeHandlerhave demonstrated negative impact on the performance of some transformations. Until this is better understood and fixed, these handlers are now optional and can be activated via the following Java properties and environment variables:hale.functions.use_index_join_handler/HALE_FUNCTIONS_USE_INDEX_JOIN_HANDLERhale.functions.use_index_merge_handler/HALE_FUNCTIONS_USE_INDEX_MERGE_HANDLERING-4464