Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15684 - redirect all logs for level ERROR and FATAL also to stderr #16054

Merged
merged 11 commits into from
Feb 29, 2024

Conversation

valenad1
Copy link
Collaborator

@valenad1 valenad1 commented Feb 1, 2024

#15684

I configured our default logging to put ERROR and FATAL log levels also to stderr

@valenad1 valenad1 force-pushed the valenad-GH-15684-add-log-to-stderr branch from dc68d67 to aa494b2 Compare February 13, 2024 16:23
@valenad1 valenad1 force-pushed the valenad-GH-15684-add-log-to-stderr branch from 0e4d4cd to 84846f4 Compare February 15, 2024 17:13
@valenad1 valenad1 changed the title GH-15684 - add stderr log to all error branches GH-15684 - redirect all logs for level ERROR and FATAL also to stderr Feb 16, 2024
Copy link
Contributor

@wendycwong wendycwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test?

@valenad1
Copy link
Collaborator Author

Is it possible to add a test?

Its more difficult than I would expect. Only think that comes to my mind is to redirect System.err to different print stream. It doesn't work for LOG.error() but only if you call System.err.println() directly. Add different appender also doesn't work. I will try something tomorrow if something comes to my mind..

@valenad1 valenad1 force-pushed the valenad-GH-15684-add-log-to-stderr branch 4 times, most recently from 1773564 to 84846f4 Compare February 22, 2024 16:12
wendycwong
wendycwong previously approved these changes Feb 22, 2024
@valenad1
Copy link
Collaborator Author

Is it possible to add a test?

Done. I have created a new stage to test it in shell directly.

@valenad1 valenad1 requested a review from wendycwong February 23, 2024 13:48
wendycwong
wendycwong previously approved these changes Feb 23, 2024
mn-mikke
mn-mikke previously approved these changes Feb 29, 2024
Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valenad1 valenad1 dismissed stale reviews from mn-mikke and wendycwong via 1bd3e30 February 29, 2024 15:10
Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valenad1 valenad1 merged commit a5f89f7 into rel-3.44.0 Feb 29, 2024
55 of 68 checks passed
@valenad1 valenad1 deleted the valenad-GH-15684-add-log-to-stderr branch February 29, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants