GH-16026: remove custom_metric_func and nparallelism from schema. #16027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tom_metric_func is not supported and nparallelism is set depending on deployment environment.
wendycwong
force-pushed
the
wendy_gh_16026_rm_custom_func_metric
branch
from
be55e9d to
85a7ee5
Compare
tomasfryda
reviewed
Jan 23, 2024
| @@ -84,7 +84,7 @@ public static class ANOVAGLMParameters extends Model.Parameters { | |||
| public int _nfolds = 0; // disable cross-validation | |||
| public Key<Frame> _plug_values = null; | |||
| public boolean _save_transformed_framekeys = false; // for debugging, save the transformed predictors/interaction | |||
| public int _nparallelism = 4; | |||
| public int _nparallelism = H2O.NUMCPUS; | |||
There was a problem hiding this comment.
Why not H2O.ARGS.nthreads?
I'm not suggesting that the nthreads would be better but I know you can specify nthreads in h2o.init(...) so I am curious when we should use the NUMCPUS and when the nthreads. NUMCPUS can be set by setting sys.ai.h2o.activeProcessorCount property which seems harder than setting nthreads.
If we don't use nthreads for parallelism, does it make sense to have it exposed in the h2o.init?
|
leave the parameter nparallelism on for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved: #16026
Removed custom_metric_func from schema: not supported.
Removed nparallelism from schema: set by deployment environment.