Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-15809: fixes loglikelihood and aic for glm generic model #16025

Merged
merged 37 commits into from
Feb 12, 2024
Merged

GH-15809: fixes loglikelihood and aic for glm generic model #16025

merged 37 commits into from
Feb 12, 2024

Conversation

syzonyuliia
Copy link
Contributor

@syzonyuliia syzonyuliia commented Jan 22, 2024 •
edited
Loading

@syzonyuliia syzonyuliia linked an issue Jan 31, 2024 that may be closed by this pull request
Allow model built earlier to be used to calculate full loglikelihood and AIC for GLM #15809
Closed
@syzonyuliia syzonyuliia added this to the 3.44.0.4 milestone Jan 31, 2024
@wendycwong wendycwong changed the base branch from rel-3.44.0 to master February 1, 2024 17:22
@syzonyuliia syzonyuliia force-pushed the GH-15809_glm_generic_model_loglikelihood_aic branch from 667b226 to 6f441f2 Compare February 2, 2024 13:48
@valenad1 valenad1 force-pushed the GH-15809_glm_generic_model_loglikelihood_aic branch from 6f441f2 to 667b226 Compare February 2, 2024 13:51
@syzonyuliia syzonyuliia force-pushed the GH-15809_glm_generic_model_loglikelihood_aic branch from 667b226 to 6f441f2 Compare February 2, 2024 13:52
@syzonyuliia-h2o
GH-15809: implement AIC and Loglikelihood calculation for GenericModel
770db34
@syzonyuliia-h2o
GH-15809: add AIC and Loglikelihood to ModelMetricsBinomial
434d444
@syzonyuliia-h2o
GH-15809: implement AIC and Loglikelihood calculations for ModelMetri…
2abfe9d 
…csBinomial
@syzonyuliia-h2o
GH-15809: add AIC and Loglikelihood to output metrics
a2e84eb
@syzonyuliia-h2o
GH-15809: update test to check AIC and Loglikelihood calculation for …
d5dcae1 
…loaded model
@syzonyuliia-h2o
GH-15809: correct betas source
7b4d93f
@syzonyuliia-h2o
GH-15809: implement AIC and loglikelihood calculation for multinomial…
c20c2d5 
… generic glm
@syzonyuliia-h2o
GH-15809: minor aic retrieval fix
455587d
@syzonyuliia-h2o
GH-15809: enable loglikelihood and AIC calculation for multinomial fa…
50fb799 
…mily
@syzonyuliia-h2o
GH-15809: remove prints
c97585a
@syzonyuliia-h2o
GH-15809: refactor
749dd43
@syzonyuliia-h2o
GH-15809: add new parameter to the constructor, and add new constructor
25ba898
@syzonyuliia-h2o
GH-15809: add dispersion_estimated parameter to GLM mojo
db5463a
@syzonyuliia-h2o
GH-15809: update and fix tests
a7269e4
@wendycwong wendycwong force-pushed the GH-15809_glm_generic_model_loglikelihood_aic branch from 56974a8 to 4a90a0b Compare February 5, 2024 22:32
@wendycwong wendycwong force-pushed the GH-15809_glm_generic_model_loglikelihood_aic branch from 2e4616d to 582c042 Compare February 10, 2024 03:54
@wendycwong wendycwong force-pushed the GH-15809_glm_generic_model_loglikelihood_aic branch from 582c042 to a6b962c Compare February 10, 2024 20:15
@wendycwong wendycwong merged commit a6bd451 into master Feb 12, 2024
68 checks passed
@wendycwong wendycwong deleted the GH-15809_glm_generic_model_loglikelihood_aic branch February 12, 2024 01:56
@mn-mikke mn-mikke removed this from the 3.44.0.4 milestone Mar 4, 2024
@krasinski krasinski mentioned this pull request Mar 21, 2024
Merged
@krasinski krasinski mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasfryda tomasfryda tomasfryda left review comments

@wendycwong wendycwong wendycwong approved these changes

@mn-mikke mn-mikke Awaiting requested review from mn-mikke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow model built earlier to be used to calculate full loglikelihood and AIC for GLM
5 participants
@syzonyuliia @wendycwong @tomasfryda @mn-mikke @syzonyuliia-h2o