Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-15989: Craft DT Example #15998

Merged
merged 8 commits into from
Aug 23, 2024
Merged

GH-15989: Craft DT Example #15998

merged 8 commits into from
Aug 23, 2024

Conversation

shaunyogeshwaran
Copy link
Contributor

@shaunyogeshwaran shaunyogeshwaran commented Jan 3, 2024 •
edited
Loading

fixes #15989
Crafted new examples for the DT algorithm to showcase the different parameters.

@shaunyogeshwaran shaunyogeshwaran added this to the 3.44.0.4 milestone Jan 3, 2024
@shaunyogeshwaran shaunyogeshwaran self-assigned this Jan 3, 2024
@shaunyogeshwaran shaunyogeshwaran linked an issue Jan 3, 2024 that may be closed by this pull request
DecisionTree pydocs updates #15989
Closed
@hannah-tillman hannah-tillman changed the title [DOCS] Craft DT Example GH-15989: Craft DT Example Jan 5, 2024
hannah-tillman
hannah-tillman previously approved these changes Jan 12, 2024
View reviewed changes
hannah-tillman
hannah-tillman previously approved these changes Jan 18, 2024
View reviewed changes
@mn-mikke mn-mikke modified the milestones: 3.44.0.4, 3.46.0.2 Mar 4, 2024
valenad1

This comment was marked as duplicate.

Sign in to view

@valenad1 valenad1 self-requested a review March 5, 2024 13:51
valenad1
valenad1 requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One example is not working and I would use different number than default.

Otherwise, LGTM, Thank you!

@valenad1 valenad1 modified the milestones: 3.46.0.2, 3.46.0.3 May 17, 2024
hannah-tillman
hannah-tillman previously approved these changes May 21, 2024
View reviewed changes
@hannah-tillman hannah-tillman requested a review from valenad1 May 21, 2024 11:50
wendycwong
wendycwong previously approved these changes Jun 7, 2024
View reviewed changes
@shaunyogeshwaran
Copy link
Contributor Author

Hello @valenad1, I've made the requested changes 👍

@valenad1 valenad1 modified the milestones: 3.46.0.3, 3.46.0.4 Jun 10, 2024
@valenad1 valenad1 removed this from the 3.46.0.4 milestone Jul 9, 2024
@valenad1 valenad1 added this to the 3.46.0.5 milestone Jul 9, 2024
@valenad1 valenad1 changed the base branch from rel-3.44.0 to rel-3.46.0 August 14, 2024 15:53
@valenad1 valenad1 dismissed stale reviews from wendycwong and hannah-tillman August 14, 2024 15:53

The base branch was changed.

valenad1
valenad1 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thank you @shaunyogeshwaran

@shaunyogeshwaran shaunyogeshwaran merged commit cd01927 into rel-3.46.0 Aug 23, 2024
67 of 71 checks passed
@shaunyogeshwaran shaunyogeshwaran deleted the sy-#15989-DT branch August 23, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valenad1 valenad1 valenad1 approved these changes

@wendycwong wendycwong wendycwong left review comments

@hannah-tillman hannah-tillman hannah-tillman left review comments

Assignees

@shaunyogeshwaran shaunyogeshwaran

Labels
docs
Projects
None yet
Milestone
3.46.0.5
Development

Successfully merging this pull request may close these issues.

DecisionTree pydocs updates
5 participants
@shaunyogeshwaran @wendycwong @valenad1 @hannah-tillman @mn-mikke