-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-15983: Craft RuleFit Examples [nocheck] [nochecks] #15984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Wendy, I would also use different values than the default in the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add examples only to the max_categorical_levels
, algorithm
, and max_num_rules
parameters?
It would be nice to add examples also for:
- min_rule_lenght
- max_rule_length
- model_type
- distribution
- rule_generation_ntrees
- rule_importance
- predict_rules
Agreed, that is something I will be able to look into. @hannah-tillman what are your thoughts on this? |
@shaunyogeshwaran Yeah adding those examples in won't be an issue. Both of those calls are in written out in the gen_rulefit.py page so instead of adding them to the bottom of the examples list you'll just add them to their respective sections like this under
|
The base branch was changed.
Jenkins still cannot run. Please change github branch name and remove the #. |
#15983
Crafted new examples for the RuleFit algorithm to showcase the different parameters.