Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-15909] Fix Jetty 9 SSL init #15824

Merged
merged 4 commits into from
Jan 22, 2024
Merged

[GH-15909] Fix Jetty 9 SSL init #15824

merged 4 commits into from
Jan 22, 2024

Conversation

krasinski
Copy link
Contributor

@krasinski krasinski commented Oct 13, 2023 •
edited
Loading

closes #15909

@krasinski krasinski requested a review from mn-mikke October 13, 2023 17:58
@mn-mikke mn-mikke mentioned this pull request Oct 18, 2023
Merged
@krasinski krasinski closed this Nov 7, 2023
@krasinski krasinski reopened this Nov 7, 2023
@krasinski krasinski changed the title [DRAFT] Fix Jetty 9 SSL init [GH-15909] Fix Jetty 9 SSL init Nov 13, 2023
@krasinski krasinski marked this pull request as ready for review November 13, 2023 11:38
@krasinski krasinski requested a review from valenad1 November 13, 2023 11:39
valenad1
valenad1 previously approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

mn-mikke
mn-mikke reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some comments describing association between classes and jetty version also mention why we're doing that and why we keep old jetty.

@krasinski krasinski linked an issue Dec 4, 2023 that may be closed by this pull request
Handle both old and new versions of Jetty despite class incompabilities related to deprecation #15909
Closed
mn-mikke
mn-mikke approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

valenad1
valenad1 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@krasinski krasinski added this to the 3.46.0.1 milestone Jan 15, 2024
@mn-mikke mn-mikke merged commit 6508c53 into master Jan 22, 2024
2 checks passed
@mn-mikke mn-mikke deleted the fix-jetty-ssl-init branch January 22, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mn-mikke mn-mikke mn-mikke approved these changes

@valenad1 valenad1 valenad1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.46.0.1
Development

Successfully merging this pull request may close these issues.

Handle both old and new versions of Jetty despite class incompabilities related to deprecation
3 participants
@krasinski @mn-mikke @valenad1