revert model type detection in AutoML SE support

h2oai · Feb 11, 2024 · bb9047d · bb9047d
1 parent 421a228
commit bb9047d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/h2o-automl/src/main/java/ai/h2o/automl/AutoMLBuildSpec.java b/h2o-automl/src/main/java/ai/h2o/automl/AutoMLBuildSpec.java
@@ -181,7 +181,7 @@ public static final class AutoMLBuildModels extends Iced {
     public double exploitation_ratio = -1;
     public AutoMLCustomParameters algo_parameters = new AutoMLCustomParameters();
     public PreprocessingStepDefinition[] preprocessing;
-    public boolean _pipelineEnabled = true; // currently used for testing until ready: to be removed
+    public boolean _pipelineEnabled = false; // currently used for testing until ready: to be removed
   }
 
   public static final class AutoMLCustomParameters extends Iced {

diff --git a/h2o-automl/src/main/java/ai/h2o/automl/modeling/StackedEnsembleStepsProvider.java b/h2o-automl/src/main/java/ai/h2o/automl/modeling/StackedEnsembleStepsProvider.java
@@ -128,13 +128,13 @@ protected boolean hasDoppelganger(Key<Model>[] baseModelsKeys) {
 
             protected String getModelType(Key<Model> key) {
               ModelingStep step = aml().session().getModelingStep(key);
-              if (step == null) { // dirty case
+//              if (step != null) {  // fixme: commenting out this for now, as it interprets XRT as a DRF (which it is) and breaks legacy tests. We might want to reconsider this distinction as XRT is often very similar to DRF and doesn't bring much diversity to SEs, and the best_of SEs currently almost always have these 2.
+//                return step.getAlgo().name();
+//              } else { // dirty case
                 String keyStr = key.toString();
-                int lookupStart = keyStr.startsWith(PIPELINE_KEY_PREFIX) ? PIPELINE_KEY_PREFIX.length() : 0; 
+                int lookupStart = keyStr.startsWith(PIPELINE_KEY_PREFIX) ? PIPELINE_KEY_PREFIX.length() : 0;
                 return keyStr.substring(lookupStart, keyStr.indexOf('_', lookupStart));
-              } else {
-                return step.getAlgo().name();
-              }
+//              }
             }
 
             protected boolean isStackedEnsemble(Key<Model> key) {