GH-15809: correct betas source

h2oai · Jan 22, 2024 · 003d8f9 · 003d8f9
1 parent 8e86ba2
commit 003d8f9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/h2o-algos/src/main/java/hex/generic/GenericModel.java b/h2o-algos/src/main/java/hex/generic/GenericModel.java
@@ -2,7 +2,7 @@
 
 import hex.*;
 import hex.genmodel.*;
-import hex.genmodel.algos.glm.GlmMojoModel;
+import hex.genmodel.algos.glm.GlmMojoModelBase;
 import hex.genmodel.algos.kmeans.KMeansMojoModel;
 import hex.genmodel.descriptor.ModelDescriptor;
 import hex.genmodel.descriptor.ModelDescriptorBuilder;
@@ -147,11 +147,8 @@ public double aic(double likelihood) {
         if (!_algoName.equals("glm")) {
             return 0;
         } else {
-            double aic = -2 * likelihood + 2 * Arrays.stream(((GlmMojoModel) this.genModel()).getBeta()).filter(b -> b != 0).count();
-            System.out.println("Bettas for AIC: " + Arrays.stream(((GlmMojoModel) this.genModel()).getBeta()).filter(b -> b != 0).count());
-            System.out.println(Arrays.toString(((GlmMojoModel) this.genModel()).getBeta()));
-            System.out.println("Gen AIC: " + aic);
-            return aic;
+            long betasCount = Arrays.stream(((GlmMojoModelBase) this.genModel()).getBeta()).filter(b -> b != 0).count();
+            return -2 * likelihood + 2 * betasCount;
         }
     }
 

diff --git a/h2o-genmodel/src/main/java/hex/genmodel/algos/glm/GlmMojoModelBase.java b/h2o-genmodel/src/main/java/hex/genmodel/algos/glm/GlmMojoModelBase.java
@@ -2,7 +2,7 @@
 
 import hex.genmodel.MojoModel;
 
-abstract class GlmMojoModelBase extends MojoModel {
+public abstract class GlmMojoModelBase extends MojoModel {
 
   boolean _useAllFactorLevels;