Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline results page tidyup #5064

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

GarethCabournDavies
Copy link
Contributor

I was doing the work from #5062 separately to Ian, and thought I'd apply the same logic/fixes to different parts of the results pages:

  • the DQ, most of the singles and the workflow/(version and throughput) pages were all in "expand all", So I have fixed this by adding the command to make wells
  • Added some things to the DQ summary page
  • In the workflow section, dax, input_map, output_map and planning are all empty. I'm not sure how to add these, so am commenting out for now, but adding a FIXME (I will add an issue as well)
  • I have tried to consolidate the injection and sensitivity pages, which were making the same plots multiple times.

Standard information about the request

This is a mix of bug fixes and new features
This change affects the offline search
This change changes result presentation / plotting
This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines

Links to any issues or associated PRs

  • The author of this pull request confirms they will adhere to the code of conduct

@GarethCabournDavies
Copy link
Contributor Author

See #5065 for the workflow pages issue

@GarethCabournDavies GarethCabournDavies added offline search v23_release_branch PRs applied to the v2.3.X release branch or to be cherry-picked if merging to master labels Feb 25, 2025
@spxiwh
Copy link
Contributor

spxiwh commented Feb 25, 2025

Do you have an example of the test workflow's HTML page with this patch applied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
offline search v23_release_branch PRs applied to the v2.3.X release branch or to be cherry-picked if merging to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants