Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t1836: Fixing "Cannot download" button padding #4327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

t1836: Fixing "Cannot download" button padding #4327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08b3e69
Fixing cannot download padding
shannonmcgurk Sep 10, 2024
3122e97
Fixing cannot download padding
shannonmcgurk Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions kahuna/public/js/components/gr-downloader/gr-downloader.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,8 @@
aria-label="Cannot download">
<gr-icon-label
gr-icon="file_download"
class="download-icon-label"
gr-tooltip="Downloading non-free images requires a lease"
>
class="cannot-download-icon-label"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works, but did you consider using the side-padded class that the other buttons use to add padding? it would mean one less CSS rule to maintain for just this version of the button

gr-tooltip="Downloading non-free images requires a lease">
Cannot download
</gr-icon-label>
</span>
Expand Down
4 changes: 4 additions & 0 deletions kahuna/public/stylesheets/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,6 +1407,10 @@ textarea.ng-invalid {
padding: 0px;
}

.results-toolbar__right gr-downloader .cannot-download-icon-label {
padding:8px;
}

.results-toolbar-item {
vertical-align: middle;
border-width: 0 1px;
Expand Down