Delete unused authorisedForDeleteImageOrUploader method on MediaAPI #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytw1
force-pushed
the
mediaapi-delete-unused-authorisedForDeleteImageOrUploader
branch
from
79849a8
to
ab856d0
Compare
|
Rebasing |
Looks like this is from before the generic auth changes. private methods which do not look like overrides and the application compiles without then.
tonytw1
force-pushed
the
mediaapi-delete-unused-authorisedForDeleteImageOrUploader
branch
from
ab856d0
to
d7a2f30
Compare
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-auth
and removed
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
labels
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (created by @tonytw1 and merged by @andrew-nowak 8 minutes and 35 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Delete 2 unused private methods.
Looks like this is from before the generic auth changes. private methods which do not look like overrides and the application compiles without then.
Complies and tests pass.
How should a reviewer test this change?
How can success be measured?
Should have zero impact; removes a piece redundant code and makes this class slightly easier to alter.
Who should look at this?
Tested? Documented?