replace some hard coded clauses of the Content-Security-Policy with config #4255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndyKilmory noticed that there were a few things hardcoded into our CSP which we decided ought to be coming from config.
For example youtube.com (introduced in #4127) is specific to a guardian add-on (https://github.com/guardian/pinboard) which is added via the
scriptsToLoad
config, so this PR extends theScriptToLoad
case class to representadditionalFrameSourcesForCSP
andadditionalImageSourcesForCSP
(to replace another hard coded pinboard thing, which makes avatars work).In the process I've removed
https://accounts.google.com
from theframe-src
portion (added in bcdcb2e) since I can't see how it would be used (although @andrew-nowak might have an idea).TEST
config uploadedTEST
✅ 🎉PROD
config uploaded