Refactor card wrapper top bar #13655
Merged
+19
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
|
Size Change: -4 B (0%) Total Size: 910 kB ℹ️ View Unchanged
|
domlander
force-pushed
the
doml/refactor/card-wrapper-top-bar
branch
from
762c431 to
dcefc55
Compare
github-actions
bot
added
dotcom-rendering
and removed
run_chromatic
domlander
force-pushed
the
doml/refactor/card-wrapper-top-bar
branch
from
dcefc55 to
c47b974
Compare
github-actions
bot
removed
the
run_chromatic
domlander
commented
Mar 20, 2025
| @@ -1505,6 +1506,8 @@ export const WithNoGap = () => { | |||
| {...basicCardProps} | |||
| imagePositionOnDesktop="left" | |||
| isOnwardContent={true} | |||
| showTopBarDesktop={false} | |||
There was a problem hiding this comment.
Onwards content doesn't have a top bar on mobile or desktop, so adding these props make sense for this story
domlander
commented
Mar 20, 2025
| @@ -407,7 +407,7 @@ export const Card = ({ | |||
| index = 0, | |||
| isFlexSplash, | |||
| showTopBarDesktop = true, | |||
| showTopBarMobile = false, | |||
| showTopBarMobile = true, | |||
There was a problem hiding this comment.
Before this change, a top bar would be shown on mobile if either showTopBarDesktop or showTopBarMobile was true
domlander
commented
Mar 20, 2025
| @@ -752,10 +752,10 @@ export const Card = ({ | |||
| return ( | |||
| <CardWrapper | |||
| format={format} | |||
| showTopBarDesktop={!isOnwardContent && showTopBarDesktop} | |||
There was a problem hiding this comment.
The Carousel calling the card component now specifies that there shouldn't be a top bar at both screen sizes when the card is Onwards Content, so this extra check isn't needed.
domlander
force-pushed
the
doml/refactor/card-wrapper-top-bar
branch
from
c47b974 to
d5151de
Compare
github-actions
bot
removed
the
run_chromatic
abeddow91
approved these changes
Mar 31, 2025
|
Seen on PROD (merged by @domlander 10 minutes and 3 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We have a couple of props
showTopBarMobileandshowTopBarDesktopthat we pass into theCardWrappercomponent. The former works as you'd expect: if true, a horizontal line will be shown above the card on mobile screen sizes. However, the latter does not work as you'd expect. A top bar is shown at all device sizes if this prop is true. This PR refactors this behaviour so that ifshowTopBarDesktopis true, a horizontal line will be shown above the card on desktop screen sizes.Why?
Code health.