Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop redirect after reject #2001

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Stop redirect after reject #2001

wants to merge 4 commits into from

Conversation

akinsola-guardian
Copy link
Contributor

@akinsola-guardian akinsola-guardian commented Mar 10, 2025 •
edited
Loading

What are you changing?

  • Removing the redirect from the onMessageChoiceSelect callback.
  • Migrating redirect function for later use to redirectToSupportSignUpPage

Why?

  • The reject all button for the Consent or Pay banner was replaced by a redirect button in Sourcepoint portal. Hence, this redirect for Reject All CorP banner interactions is no longer required.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 8dcc29c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/libs labels Mar 10, 2025
@akinsola-guardian akinsola-guardian changed the title Al stop redirect after reject Stop redirect after reject Mar 10, 2025
@akinsola-guardian akinsola-guardian marked this pull request as ready for review March 11, 2025 09:39
@akinsola-guardian akinsola-guardian requested review from a team as code owners March 11, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@guardian/libs 📦 npm Affects a @guardian package on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akinsola-guardian