Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source icons #1981

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update source icons #1981

wants to merge 3 commits into from

Conversation

abeddow91
Copy link
Contributor

@abeddow91 abeddow91 commented Feb 27, 2025

What are you changing?

The following icons have been added to source:

'add-to-basket': 'Add to basket',
'all-recipes': 'All recipes',
'bookmark-round-filled': 'Bookmarked',
'bookmark-round-outlined': 'Bookmark',
chef: 'Chef',
'chevron-left-single-small': 'Chevron left',
'chevron-right-single-small': 'Chevron right',
'clock-filled': 'Clock',
'clock-outlined': 'Clock',
cuisines: 'Cuisines',
diets: 'Diets',
discover: 'Discover',
'folder-filled': 'Folder',
folder: 'Folder',
'headphones-filled': 'Listening',
'headphones-outlined': 'Listen',
'headphones-round-filled': 'Listening',
'headphones-round-outlined': 'Listen',
list: 'list',
'meal-types': 'Meal types',
'newspaper-archive': 'Newspaper archive',
'newsletter-outlined': 'Newsletter',
'padlock-locked': 'Padlock locked',
'padlock-unlocked': 'Padlock unlocked',
'share-round-filled': 'Share',
'share-round-outline': 'Share',
'shopping-list': 'Shopping list',
'shopping-basket': 'Shopping basket',
sort: 'Sort',
'text-size-round-filled': 'Text size active',
'text-size-round-outline': 'Text size',
'transparent-arrow-left-straight-round': 'Go back',
'white-arrow-left-straight-round': 'Go back',

The following icons have been updated in source:

newsletter -> ‘newsletter-filled': 'Newsletter',

The following icons have been removed in source:

    SvgAlertTriangle
    SvgDirectDebitWide

Why?

This was requested by the design system team

@abeddow91 abeddow91 requested review from a team as code owners February 27, 2025 17:21
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 5c2a6ec

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Feb 27, 2025
@abeddow91 abeddow91 self-assigned this Feb 27, 2025
@abeddow91 abeddow91 requested review from a team as code owners February 27, 2025 17:32
Copy link
Contributor

@andrewHEguardian andrewHEguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@SiAdcock SiAdcock added the run_chromatic Runs chromatic when label is applied label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants