Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear wrong letters #1978

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Clear wrong letters #1978

wants to merge 1 commit into from

Conversation

DanielCliftonGuardian
Copy link
Contributor

What are you changing?

Why?

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 2ff0dd6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Feb 27, 2025
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@SiAdcock
Copy link
Contributor

SiAdcock commented Feb 27, 2025

Three reasons users have said they'd prefer us to clear incorrect letters instead of striking them out:

  1. The contrast of the strikethrough is hard to get right. Too much contrast and it obscures the letter. Too little and it is too feint for some users to discern. Some users are already struggling with this.
  2. if you have a lot of crossed out letters and only one or two that are correct, it's really hard to distinguish. There's a lot of visual noise. (see screenshot)
  3. leaving the letters in place means users have a harder time "imagining" a different word in that space. They have to manually delete the letters, which is a bit of a drudge when you're just trying to relax / have fun.

Screenshot 2025-02-27 at 16 09 09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants