Move design-tokens into @guardian/source
#1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w-tokens # Conflicts: # libs/@guardian/source/src/design-tokens/plugins/space.js # libs/@guardian/source/src/design-tokens/plugins/typography.js # libs/@guardian/source/src/design-tokens/tokens.config.js
🦋 Changeset detectedLatest commit: fac9a1c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
…w-tokens # Conflicts: # libs/@guardian/source/src/design-tokens/cobalt-plugins/breakpoints.js # libs/@guardian/source/src/design-tokens/tokens.config.js
oliverabrahams
approved these changes
Aug 13, 2024
Brings `remSize`, `remIconSize`, `remHeight` and `remWidth` into line with `remSpace`, by changing their values from numbers (of rems) to strings with `rem` units.
# Conflicts: # libs/@guardian/source/src/foundations/size/size.ts # libs/@guardian/source/src/foundations/space/space.ts
# Conflicts: # libs/@guardian/source/src/foundations/size/size.ts # libs/@guardian/source/src/foundations/space/space.ts
…w-tokens # Conflicts: # libs/@guardian/source/src/design-tokens/lib/convert-value.js # libs/@guardian/source/src/foundations/utils/convert-value.test.ts # libs/@guardian/source/src/foundations/utils/convert-value.ts
sndrs
commented
Aug 13, 2024
Co-authored-by: Joe Cowton <[email protected]> Co-authored-by: Oliver Abrahams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
Removes
@guardian/design-tokenspackage and adds the tokens directly to@guardian/source.Why?
Having it as separate package was preparation for a world that never came, and adds complexity and indirection to the process of editing design tokens.
This also allows us to calculate
foundationsvalues during build, rather than at the point of consumption.And that relieves user's devices of this overhead and makes it unnecessary to include the design tokens JSON in consumer's bundles.
A CSTI Mobbing Release© by @sndrs, @oliverabrahams and @jamesmockett.