Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator.py: Restore pre-building gir with build/progress output #1613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Nov 5, 2024

  1. generator.py: Restore pre-building gir with build/progress output

    In commit c6ba79e ("generator.py: Use cargo run instead of guessing
    path") the `cargo build` command on the default (hardcoded) `"gir"`
    directory was replaced with a single `cargo run` for correctly finding
    the right executable.
    
    This isn't an issue given that `cargo run` also builds the tool, and
    above all makes it easier / more correct to find the binary as the
    primary reason for that commit, but it does make us lose the build log
    as a progress indicator (thanks to `--quiet` and capturing `stderr`).
    In addition, it causes the first `` => Looking in path `xxx` `` item
    to take a very long time without aforementioned progres indication,
    making the user wonder what is going on.
    
    By building `gir` again with a separate `cargo build` invocation before
    running, this issue is alleviated somewhat.
    MarijnS95 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3e437a6 View commit details
    Browse the repository at this point in the history