generator.py: Use cargo run instead of guessing path

[sophie-h]

Currently, the script just guesses a target path based on the default config. This fails if the project or the user has configured a different target directory.

This code is shorter and more correct.

[MarijnS95]

Shouldn't that be DEFAULT_GIR_DIRECTORY? Now you're assuming that custom projects always have a submodule named gir? Perhaps we better fold this in with the configuration parameter gir_path somehow?

[sophie-h]

Shouldn't that be DEFAULT_GIR_DIRECTORY?

Could make sense to change this. But I'm currently following the previous code where it was hardcoded.

Now you're assuming that custom projects always have a submodule named gir?

That's nothing new, it's the same as with the previous code:

def update_workspace():
    return run_command(["cargo", "build", "--release"], "gir")

Perhaps we better fold this in with the configuration parameter gir_path somehow?

Well, that path is a binary path. Not sure how you would couple that with a source directory for gir.

[MarijnS95]

By adding a "defaulted" "gir directory" path argument, and making it mutually exclusive with --gir-path perhaps? That way the default (hardcoded) "gir" suddenly becomes visible too.

[sdroege]

Looks good to me. Any other comments?

[MarijnS95]

One downside of this, found now that I started using this, is that run_command("cargo build ...") which was used previously does not capture stdout/stderr. The newly used stdout, stderr = await spawn_process(...) inherently captures output, meaning that the first => Looking in path `some-crate` now takes very long without any progress indication.

[sophie-h]

I don't remember how the old solution solved that, but you could bring back a separate cargo build call and use cargo run after that. With this, the run shouldn't have to do build anymore.

[MarijnS95]

@sophie-h sure, I'll look into it 👍

Additionally, it looks like cargo build/run properly take file locks, but notice that the invocation to spawn_gir() is massively parallelized (in i.e. a tree like gstreamer-rs) when invoked without a path filter.

[MarijnS95]

Finally tackled in #1613.