Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade repo to golang 1.21.4 #163

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

upgrade repo to golang 1.21.4 #163

wants to merge 10 commits into from

Conversation

ceschae
Copy link

@ceschae ceschae commented Jan 17, 2025

Description

Fixes #162

CI has been breaking since #142, this fixes that issue.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes

Updated golang version for repo to v1.21.4.

@ceschae ceschae requested a review from brikis98 as a code owner January 17, 2025 18:45
@ceschae ceschae changed the title upgrade repo to golang 1.21.4 [WIP] upgrade repo to golang 1.21.4 Jan 17, 2025
@ceschae
Copy link
Author

ceschae commented Jan 17, 2025

ugh i got too excited and missed that the tests failed. hold please

@ceschae ceschae changed the title [WIP] upgrade repo to golang 1.21.4 upgrade repo to golang 1.21.4 Jan 17, 2025
@ceschae
Copy link
Author

ceschae commented Jan 17, 2025

ok, fixed the test step, needed a new docker image. this is ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed in CI
1 participant