xds: Enable deprecation warnings #11998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
commented
Apr 4, 2025
|
There are some build failures in checks. |
|
Yeah, I am going through them. I started yesterday but there were quite a few usages of the deprecated classes in the tests. (I suspect I accidentally only did :compileJava when building before sending out the PR.) |
The security code referenced fields removed from gRFC A29 before it was finalized.
Note that this fixes a bug in CommonTlsContextUtil where CombinedValidationContext was not checked. I believe this was the only location with such a bug as I audited all non-test usages of has/getValidationContext() and confirmed they have have a cooresponding has/getCombinedValidationContext().
ejona86
force-pushed
the
xds-deprecation
branch
from
87760b5 to
d6132c1
Compare
|
I fixed the tests and I rebased past f79ab2f which conflicted (because a deprecated thing was deleted). |
kannanjgithub
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The security code referenced fields removed from gRFC A29 before it was finalized.