Allow setting process multiplier via ENV variable #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the CLI accepts `-m` or `--multiply-processes` with a `COUNT` value which is a multiple applied to the number of parallel process to be spun up. This commit adds the aditional abiity to modify `COUNT` by specifing `PARALLEL_TEST_MULTIPLE` which will be parsed into a float.
aramprice
changed the title
|
how about PARALLEL_TEST_MULTIPLY_PROCESSES so it stays symmetric ? also what is the usecase for this ? |
|
That is more symmetric, I was aiming for short(er). I don't have any attachment to the naming through, feel free to change (or I can). Use case is wanting to call the gem's built in rake tasks rather than having to reconstruct the command building logic in |
|
renaming + fixing tests #993 |
|
FYI yanked that and released 4.10.1 to avoid api change from a method rename in #993 |
|
@grosser - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CLI accepts
-mor--multiply-processeswith aCOUNTvalue which is a multiple applied to the number of parallel process to be spun up.This commit adds the aditional abiity to modify
COUNTby specifingPARALLEL_TEST_MULTIPLEwhich will be parsed into a float.Thank you for your contribution!
Checklist
master(if not - rebase it).code introduces user-observable changes.